asiekierka / FoamFix

Minecraft memory usage optimization mod. Please note that code contained herein is not a suggestion for Minecraft unless explicitly declared elsewhere, in writing, by the rightsholder(s).
http://asie.pl/foamfix
149 stars 23 forks source link

1.12 shading issue with forestry #143

Open Zygus42 opened 6 years ago

Zygus42 commented 6 years ago

foamfix-0.9.9-1.12.2-anarchy forestry_1.12.2-5.8.0.284 forge-1.12.2-14.23.3.2673-installer-win No other mods.

A shading fault with forestry stairs. Does not happen with normal stairs, nor any other forestry block, but does happen with all forestry stairs, and does not fix itself with lighting updates, lighting changes, chunk reload or save reload. Removing foamfix removes the problem.

2018-05-03_14 13 53

temp1011 commented 6 years ago

Have you tried changing disableStairSlabCulling in the forge config?

asiekierka commented 6 years ago

@temp1011 No changes to forge.cfg should be required for FoamFix to work.

@Zygus42 Upgrade to 0.9.9.1 and let me know if that helps any. I experimented with a cheap "minimum lighting" implementation, but it didn't work very well, so I removed it for now.

asiekierka commented 6 years ago

https://gist.github.com/acidjazz

Note crashes somewhere on Page 2.

acidjazz commented 6 years ago

in case they get older:

https://gist.github.com/acidjazz/d44753fcc4fab35d3d1eea577214adc9 https://gist.github.com/acidjazz/f08364bd70aa1de38b58bf711095a9c1 https://gist.github.com/acidjazz/1cfd25f369c57ea5c89bfb18e8df381d https://gist.github.com/acidjazz/f5cf723f5be87d3aa7f65aef6933b4c8 https://gist.github.com/acidjazz/32088081eea44aa991136f268d4c9a46