search

asiekierka / FoamFix

Minecraft memory usage optimization mod. Please note that code contained herein is not a suggestion for Minecraft unless explicitly declared elsewhere, in writing, by the rightsholder(s).
http://asie.pl/foamfix
150 stars 23 forks source link

[Minor] version number in mod list #68

Open ghost opened 7 years ago

ghost commented 7 years ago

In the ingame mod list, FoamFix displays @VERSION@ instead of the version number and @VERSION@ (@VERSION@) in the mod's description.

Minecraft: 1.12 FoamFix: 0.7.4 anarchy

3TUSK commented 6 years ago

Still an issue in FoamFix 0.9.4, Anarchy Version.

Screenshot: 2018-03-02_13 42 53

The variable placeholder should be ${version}, not @VERSION@, I guess... or the replace "@VERSION@", project.version statement not working on mcmod.info? https://github.com/asiekierka/FoamFix/blob/ce9c8c83d0920fb85a1e40a2f0f853a5896f14a6/src/main/resources/mcmod.info#L7

Although fixing this does not affect the mod functionality a bit, it might help things that scan the mcmod.info to retrieve mod metadata, for example you can observe this in MultiMC: screen shot 2018-03-02 at 13 48 47

JacobTDC commented 4 years ago

Sorry to revive an old issue, but I was about to make an issue on this same problem. It still exists as of FoamFix 0.10.10 (1.12.2). Would be a nice fix.