search

asiekierka / MageMC

FLOSS graphics extension mod
6 stars 0 forks source link

Crash: Possible cross mod issue with Xero's Minimap #11

Open Dragnier opened 5 years ago

Dragnier commented 5 years ago

Pretty sure it crashed because of this code in MageMCPatcherCustomColors in their mod:

image.getRGB((int) (coords[0] image.getWidth()), (int) (coords[1] image.getHeight()));

It's possible for it to request RGB at an out of bounds coordinate because coords[0] or coords[1] can be 1.0 while the max index for the x coordinate is image.getWidth() - 1 and not image.getWidth(). So this can probably crash even without my world map mod.

Quoted from https://minecraft.curseforge.com/projects/xaeros-minimap/issues/30