search

asiekierka / MageMC

FLOSS graphics extension mod
6 stars 0 forks source link

Major console spam (and possible crash?) #13

Open IdrisQe opened 5 years ago

IdrisQe commented 5 years ago

I opened a world after installing a few resource packs and immediately began having HUGE console spam from MAGE. [00:29:23] [Client thread/WARN] [mage]: Non-standard lightmap size found: 768 This would appear SEVERAL times per second and before long, even when paused, my instance crashed. I don't know if the crash was caused by this mod or another mod that was giving me major issues at the time too, but this is... Rather annoying, especially as someone with an SSD who doesn't want a ridiculous number of writes to a logfile.

The resource pack I assume is the "culprit": https://www.curseforge.com/minecraft/texture-packs/cy4ns-lighting

asiekierka commented 5 years ago

Well, that means this specific resource pack is probably not yet supported! It's warning you constantly because the lightmap is constantly re-calculated.

IdrisQe commented 5 years ago

Well, that means this specific resource pack is probably not yet supported! It's warning you constantly because the lightmap is constantly re-calculated.

Huhhh... I also have Optifine installed, which is what it says to use for the lightmap (and because rendering bugs aside, I can't pass up the performance gains). After all this, I went and turned off the lightmap settings in your config- have yet to check if that fixed it though.

Might I suggest a check to see if Optifine/MCPatcher is being used, and, if it is, to auto-disable the parts of the mod covered by those? I mean, if that isn't too difficult. (Kinda surprised it didn't to be honest since the mod loading order would suggest MAGE (M) would load before Optifine (O) so Optifine would take precedence?... unless Optifine does weird stuff, which it probably does because it's Optifine. or... I dunno < ^>)

It doesn't make much sense to default to your (presumably incomplete and not fully supporting) lightmap ... renderer? (sorry, I have absolutely no idea how lightmaps work, is it a renderer? I assume it's a renderer.) when something else is installed that handles it.

If that ISN'T possible I fully understand, since like... Optifine being Optifine, I wouldn't be surprsied if it wasn't detectable or something.

IdrisQe commented 5 years ago

Yeahhhh... Despite having B:"mage:customLightmap"=false and B:"mage:trueDarkness"=false, I'm still getting the spam. I'm not sure if that should still be happening with MAGE's lightmap ... renderer? ... being disabled. But it is.

Circine commented 5 years ago

For what it's worth, I get this spam with Pixel Reality Luminance's lightmap, but MAGE's features all seem to work with it anyway. No crashes.