Connected textures no longer work in Unlimited Chisel Works

[ccfb3ee765a58cae]

Using latest versions of Chisel, UCW, and CTM:

System info:

Java is version 1.8.0_222, using 64-bit architecture.

AMD A8-7410 APU with AMD Radeon R5 Graphics
Advanced Micro Devices, Inc. [AMD/ATI] Mullins [Radeon R4/R5 Graphics] (rev 45)

Subsystem: Dell Mullins [Radeon R4/R5 Graphics]

Kernel driver in use: amdgpu

OpenGL version string: 4.5 (Compatibility Profile) Mesa 19.2.1

Main Class:
  net.minecraft.launchwrapper.Launch

Native path:
  /home/redacted/.local/share/multimc/instances/unlimited chisel works test/natives

Libraries:
  /home/redacted/.local/share/multimc/libraries/net/java/jinput/jinput/2.0.5/jinput-2.0.5.jar
  /home/redacted/.local/share/multimc/libraries/net/java/jutils/jutils/1.0.0/jutils-1.0.0.jar
  /home/redacted/.local/share/multimc/libraries/org/lwjgl/lwjgl/lwjgl/2.9.4-nightly-20150209/lwjgl-2.9.4-nightly-20150209.jar
  /home/redacted/.local/share/multimc/libraries/org/lwjgl/lwjgl/lwjgl_util/2.9.4-nightly-20150209/lwjgl_util-2.9.4-nightly-20150209.jar
  /home/redacted/.local/share/multimc/libraries/com/mojang/patchy/1.1/patchy-1.1.jar
  /home/redacted/.local/share/multimc/libraries/oshi-project/oshi-core/1.1/oshi-core-1.1.jar
  /home/redacted/.local/share/multimc/libraries/net/java/dev/jna/jna/4.4.0/jna-4.4.0.jar
  /home/redacted/.local/share/multimc/libraries/net/java/dev/jna/platform/3.4.0/platform-3.4.0.jar
  /home/redacted/.local/share/multimc/libraries/com/ibm/icu/icu4j-core-mojang/51.2/icu4j-core-mojang-51.2.jar
  /home/redacted/.local/share/multimc/libraries/net/sf/jopt-simple/jopt-simple/5.0.3/jopt-simple-5.0.3.jar
  /home/redacted/.local/share/multimc/libraries/com/paulscode/codecjorbis/20101023/codecjorbis-20101023.jar
  /home/redacted/.local/share/multimc/libraries/com/paulscode/codecwav/20101023/codecwav-20101023.jar
  /home/redacted/.local/share/multimc/libraries/com/paulscode/libraryjavasound/20101123/libraryjavasound-20101123.jar
  /home/redacted/.local/share/multimc/libraries/com/paulscode/librarylwjglopenal/20100824/librarylwjglopenal-20100824.jar
  /home/redacted/.local/share/multimc/libraries/com/paulscode/soundsystem/20120107/soundsystem-20120107.jar
  /home/redacted/.local/share/multimc/libraries/io/netty/netty-all/4.1.9.Final/netty-all-4.1.9.Final.jar
  /home/redacted/.local/share/multimc/libraries/com/google/guava/guava/21.0/guava-21.0.jar
  /home/redacted/.local/share/multimc/libraries/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar
  /home/redacted/.local/share/multimc/libraries/commons-io/commons-io/2.5/commons-io-2.5.jar
  /home/redacted/.local/share/multimc/libraries/commons-codec/commons-codec/1.10/commons-codec-1.10.jar
  /home/redacted/.local/share/multimc/libraries/com/google/code/gson/gson/2.8.0/gson-2.8.0.jar
  /home/redacted/.local/share/multimc/libraries/com/mojang/authlib/1.5.25/authlib-1.5.25.jar
  /home/redacted/.local/share/multimc/libraries/com/mojang/realms/1.10.22/realms-1.10.22.jar
  /home/redacted/.local/share/multimc/libraries/org/apache/commons/commons-compress/1.8.1/commons-compress-1.8.1.jar
  /home/redacted/.local/share/multimc/libraries/org/apache/httpcomponents/httpclient/4.3.3/httpclient-4.3.3.jar
  /home/redacted/.local/share/multimc/libraries/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar
  /home/redacted/.local/share/multimc/libraries/org/apache/httpcomponents/httpcore/4.3.2/httpcore-4.3.2.jar
  /home/redacted/.local/share/multimc/libraries/it/unimi/dsi/fastutil/7.1.0/fastutil-7.1.0.jar
  /home/redacted/.local/share/multimc/libraries/org/apache/logging/log4j/log4j-api/2.8.1/log4j-api-2.8.1.jar
  /home/redacted/.local/share/multimc/libraries/org/apache/logging/log4j/log4j-core/2.8.1/log4j-core-2.8.1.jar
  /home/redacted/.local/share/multimc/libraries/com/mojang/text2speech/1.10.3/text2speech-1.10.3.jar
  /home/redacted/.local/share/multimc/libraries/net/minecraftforge/forge/1.12.2-14.23.5.2847/forge-1.12.2-14.23.5.2847-universal.jar
  /home/redacted/.local/share/multimc/libraries/net/minecraft/launchwrapper/1.12/launchwrapper-1.12.jar
  /home/redacted/.local/share/multimc/libraries/org/ow2/asm/asm-all/5.2/asm-all-5.2.jar
  /home/redacted/.local/share/multimc/libraries/org/jline/jline/3.5.1/jline-3.5.1.jar
  /home/redacted/.local/share/multimc/libraries/com/typesafe/akka/akka-actor_2.11/2.3.3/akka-actor_2.11-2.3.3.jar
  /home/redacted/.local/share/multimc/libraries/com/typesafe/config/1.2.1/config-1.2.1.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/scala-actors-migration_2.11/1.1.0/scala-actors-migration_2.11-1.1.0.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/scala-compiler/2.11.1/scala-compiler-2.11.1.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/plugins/scala-continuations-library_2.11/1.0.2/scala-continuations-library_2.11-1.0.2.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/plugins/scala-continuations-plugin_2.11.1/1.0.2/scala-continuations-plugin_2.11.1-1.0.2.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/scala-library/2.11.1/scala-library-2.11.1.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/scala-parser-combinators_2.11/1.0.1/scala-parser-combinators_2.11-1.0.1.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/scala-reflect/2.11.1/scala-reflect-2.11.1.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/scala-swing_2.11/1.0.1/scala-swing_2.11-1.0.1.jar
  /home/redacted/.local/share/multimc/libraries/org/scala-lang/scala-xml_2.11/1.0.2/scala-xml_2.11-1.0.2.jar
  /home/redacted/.local/share/multimc/libraries/lzma/lzma/0.0.1/lzma-0.0.1.jar
  /home/redacted/.local/share/multimc/libraries/java3d/vecmath/1.5.2/vecmath-1.5.2.jar
  /home/redacted/.local/share/multimc/libraries/net/sf/trove4j/trove4j/3.0.3/trove4j-3.0.3.jar
  /home/redacted/.local/share/multimc/libraries/org/apache/maven/maven-artifact/3.5.3/maven-artifact-3.5.3.jar
  /home/redacted/.local/share/multimc/libraries/com/mojang/minecraft/1.12.2/minecraft-1.12.2-client.jar

Native libraries:
  /home/redacted/.local/share/multimc/libraries/net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5-natives-linux.jar
  /home/redacted/.local/share/multimc/libraries/org/lwjgl/lwjgl/lwjgl-platform/2.9.4-nightly-20150209/lwjgl-platform-2.9.4-nightly-20150209-natives-linux.jar
  /home/redacted/.local/share/multimc/libraries/com/mojang/text2speech/1.10.3/text2speech-1.10.3-natives-linux.jar

Mods:
  [✔️] AutoRegLib-1.3-32
  [✔️] Chisel-MC1.12.2-1.0.0.42
  [✔️] CTM-MC1.12.2-1.0.0.29
  [✔️] Quark-r1.6-177
  [✔️] UnlimitedChiselWorks-0.3.0

[Goy288]

So I think I might have found a somewhat tedious solution to the problem.

You see, this not only effects connected textures, but also every block with special properties, such as randomization.

As you can see, some of the textures are way too large(aside from the one I'm looking at, I fixed that one), due to none of the special properties registering. These properties are put into special .MCMETA files, to be loaded by CTM, and without those files, none of these properties register.

I learnt that a way to fix it, is to load in a .MCMETA file via the resource loader and have it replace the auto generated texture made by UnlimitedChiselWorks, but there are two issues with this solution.

1. You need to add the .MCMETA files into all the proper folders, which would be quite tedious.
2. On top of that, the .MCMETA files don't seem to register in the resource loader unless if there's a texture put beside it. So on top of the first issue, you'll also need to somehow extract the autogenerated textures, and place them into their proper folders.

[asiekierka]

Please try https://asie.pl/files/UnlimitedChiselWorks-0.3.1-test1.jar

[Goy288]

Alright, after some quick testing, it's close to being fixed.

All the textures look right, except for the ones that connect. While the blocks certainly connect with one another, they appear to call upon the wrong texture for each one.

After testing with some other Celtic blocks, the textures that are grabbed seem to be different, so it appears that the Celtic block using the same type of texture on the left is just a coincidence, or at least I think it is.

If it helps, I should also clarify that the brown bricks are in fact mud bricks.

[cridenour]

Using 0.3.1, the textures connected but are miscolored.

[asiekierka]

I'm aware, just out of time to fix it for at least the next few days.

[cridenour]

No worries - if you have an pointers on where to start, happy to mess around and potentially submit a PR.

[asiekierka]

The code as-is for UCW is a fragile and ugly mess. I do not wish working on it upon anyone, and explaining it would probably take more time than me actually fixing it.

[asiekierka]

There we go.