search

asiekierka / nitrotracker

A Fasttracker II style tracker for the Nintendo DS
71 stars 5 forks source link

Sample selection glitch and zoom issues on large files BUG #21

Open deadpahn opened 1 year ago

deadpahn commented 1 year ago

Sample selection screen has glitching behavior see video below. https://user-images.githubusercontent.com/1032331/227416087-a9a35325-b18b-4aaf-bb08-9b6a6e17239e.mp4

asiekierka commented 1 year ago

Do you mean these blinking triangles? That's a performance issue and not something that can be easily fixed with the current codebase (no UI double-buffering).

deadpahn commented 1 year ago

Do you mean these blinking triangles? That's a performance issue and not something that can be easily fixed with the current codebase (no UI double-buffering).

It's the lack of highlighting on big files and also the Zoom doesn't work for big files sometimes. The triangles I thought were related to the highlight issue.

asiekierka commented 1 year ago

I've tried to reproduce it, but I'm not sure if I can come up with a sample necessary to do so. Could you please provide a copy of one?

deadpahn commented 1 year ago

I think the "glitch" I was perceiving was from the color of the highlight being so close to the color of the waveform. This will produce the same effect. Since the sample volume is so high, it looks like nothing is being highlighted when in fact it is (the color is too similar to the waveform).

long_sample.wav.tar.gz (can't attach .wav files to this report)

For the "zoom" part it's kind of tricky to reproducing, and in trying to do so, I realized it can be worked around by spamming the zoom in and out for a couple of seconds.

asiekierka commented 1 year ago

Regarding the highlight issue, how's this?:

deadpahn commented 1 year ago

Looks GREAT!

On Fri, Apr 7, 2023 at 3:34 PM Adrian Siekierka @.***> wrote:

Regarding the highlight issue, how's this?:

https://camo.githubusercontent.com/df238e6515d74a9aad68c707880bad8bd474a8371d7b78521932791b6fb7cc4a/68747470733a2f2f696d672e617369652e706c2f515073562e706e67

— Reply to this email directly, view it on GitHub https://github.com/asiekierka/nitrotracker/issues/21#issuecomment-1500579721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH4BC5OU4PARQDZHHLZ6IDXABT25ANCNFSM6AAAAAAWGA2FPM . You are receiving this because you commented.Message ID: @.***>