search

asiekierka / nitroustracker

Unofficial fork of 0xtob's NitroTracker, a Fasttracker II-style tracker for the DS.
76 stars 5 forks source link

Fix 'B' notes showing as 'H' in the pattern editor #108

Closed exelotl closed 3 months ago

exelotl commented 6 months ago

This PR fixes a mistake in the pattern display whereby a note such as 'B-4' would render as 'H-4'.

Before: image

After: image

deadpahn commented 6 months ago

What red (blue) letter day. This was one of the funniest quirks about NT.

asiekierka commented 6 months ago

In Germany, Russia, Poland and the Scandinavian countries, the white key before the C is called "h". In English-speaking countries, however, this note is called "b".

I don't think this is a mistake, actually. I think this is a localization error, and I'm not sure if I want to get rid of it entirely, honestly ^^ It speaks to the identity of its creators across time.

exelotl commented 6 months ago

ah! okay, I was wondering why 0xtob would've gone through the effort to add H to the spritesheet in the first place, it all makes sense now. I'm also fine with keeping it, I mean potentially it could be a setting, but that seems like overkill lol.

Unless you think having it as an easter egg could work? (e.g. tapping the NitrousTracker logo toggles it?)

deadpahn commented 3 months ago

We can probably close this PR now @exelotl since it's not going to be merged into the main repo