search

asiekierka / nitroustracker

Unofficial fork of 0xtob's NitroTracker, a Fasttracker II-style tracker for the DS.
76 stars 5 forks source link

Changes the sound data size #88

Closed deadpahn closed 11 months ago

deadpahn commented 12 months ago

https://github.com/asiekierka/nitrotracker/issues/81

My C++ journey continues and after several hours I was able to figure out how to extend the recording time back to normal. This fix allows for up to 8 seconds. I tested on my Japanese DSi via sdcard slot. My guess from the looks of it when tobmic was deprecated the length was shortened. Also, the functionality was different for when HOLDING a and simply running the record by pressing B. With my change, both have a length of around 8 seconds.

WHAT WOULD BE COOL, is a check box to be able to record in 8bit and maybe make it even longer. I sometimes like to sample videogames or movie monologues for intros.

Anyway, this works on my machine lol

deadpahn commented 12 months ago

I did just notice that if I go over the 8 second limit, anything else will be truncated to merely 1 second (even if I leave it recording longer). Not sure if the window should close after the time limit, or if the buffer should keep going (adding to the sample but subtracting the beginning). I think letting the user know, and closing the window when the buffer reaches its end is fair enough.

asiekierka commented 11 months ago

The original value was correct. 256*1024 = 16384*2*8 = 8 seconds of 16384 Hz 16-bit samples.

Something else must be broken.

asiekierka commented 11 months ago

https://github.com/asiekierka/nitrotracker/commit/cfc92fefbd9bd34f9bec5dd8675a02af9661cd1d

asiekierka commented 11 months ago

(For longer recording than 8 seconds, might want to open a merge request.)