search

asieradzk / RL_Matrix

Deep Reinforcement Learning in C#
Other
58 stars 2 forks source link

Align with the Stable-baselines3 framework? #13

Open GeorgeS2019 opened 1 week ago

GeorgeS2019 commented 1 week ago

I have written reasons why this is important for your degree; https://github.com/dotnet/TorchSharp/discussions/710#discussioncomment-9825413

asieradzk commented 1 week ago

  1. Instead of whats relevant to my dissertation I want to focus on best programming practices in modern C# and apply SOLID to the best of my ability. Aligning with SB3 is just going to make code-base a lot worse and less maintanable. If anything they (SB3 authors) should align with RLMatrix. 😎

  2. This project aims to provide a replacement to RLib rather than SD3 https://docs.ray.io/en/latest/rllib/index.html and I am going to gear it towards use with game engines.

  3. In later versions you will not have to implement IEnv interfaces by hand but rather use attributes and source generator will cook up relevant class for you, so you don't need to worry about it!