Notification protocol should define message charset

asif29acca / android-notifier

Automatically exported from code.google.com/p/android-notifier

0 stars 0 forks source link

Notification protocol should define message charset #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Looking at the code, I see that android-notifier calls getBytes() on messages 
without specifying a charset thus making the message encoding platform 
dependent. This manifests itself in the desktop app with accentuated characters 
not showing correctly.

The notification protocol should define a charset to be used in all messages 
such as ISO-8859-1.

Original issue reported on code.google.com by lehph...@gmail.com on 30 Aug 2010 at 2:16

GoogleCodeExporter commented 9 years ago

Very reasonable.
I'll change it to be UTF8 unless you have some reason to believe 8859 would be 
better.

Original comment by rdamazio@gmail.com on 30 Aug 2010 at 4:36

Changed state: Accepted
Added labels: Component-Communication, Component-Docs, Maintainability, OpSys-Android, OpSys-Linux, OpSys-OSX, Priority-High
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

UTF-8 is ok, thanks.

Original comment by lehph...@gmail.com on 30 Aug 2010 at 5:30

GoogleCodeExporter commented 9 years ago

Original comment by rdamazio@gmail.com on 12 Sep 2010 at 6:29

Changed state: Started

GoogleCodeExporter commented 9 years ago

Done in r230.

Original comment by rdamazio@gmail.com on 12 Sep 2010 at 6:32

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Original comment by rdamazio@gmail.com on 19 Sep 2010 at 6:43

Changed state: Released