search

asika32764 / vue-animate

A port of Animate.css for use with transitions in Vue.js 2.0 / 3.0 and Alpine.js.
https://vue-animate.simular.co/
Other
1.36k stars 132 forks source link

Malformed css property #21

Closed freitasskeeled closed 6 years ago

freitasskeeled commented 6 years ago

Hi,

I noticed a bug with the "make-transitions" mixin. The property animation-name is created with quotes and that is invalid css.

Here is a short gif showing the problem: GIF

To fix it, I simply removed the single quotes from the 4 animation-name property definitions.

Best regards,

Rui Freitas

asika32764 commented 6 years ago

Seem's the main subject of https://github.com/asika32764/vue2-animate/pull/20 to solved.

freitasskeeled commented 6 years ago

Hi,

I didn't notice the PR. I search for issues but not PR (my bad).

Do you an estimation to when that PR is going to be merged?

Best regards,

Rui Freitas

asika32764 commented 6 years ago

The PR author says he will do some update but I didn't see new commits, I will merge it maybe this weekend.

asika32764 commented 6 years ago

2.1.0 has released https://github.com/asika32764/vue2-animate/releases/tag/2.1.0