Bugfix for sending xml with special characters.

asimlqt / php-google-spreadsheet-client

A PHP library for accessing and manipulating Google Spreadsheets

Other

544 stars 152 forks source link

Closed erikverheij closed 8 years ago

erikverheij commented 9 years ago

When sending special characters like <,> and & the xml gets broken. This is a fix using htmlspecialchars with the ENT_XML1 flag.

I think it would even be better to form all the xml using SimpleXML like hectorbenitez did. https://github.com/asimlqt/php-google-spreadsheet-client/pull/48/files

SimpleXML handles such cases for you.

ghost commented 8 years ago

Hello. Any update on this pull request? Will it be approved?

asimlqt commented 8 years ago

Thanks for the PR @erikverheij

I'm currently working on replacing the string based approach with SimpleXML as you mentioned.

I'm going to decline this PR as it will no longer be relevant.