asimlqt / php-google-spreadsheet-client

A PHP library for accessing and manipulating Google Spreadsheets
Other
544 stars 152 forks source link

Improved verbosity of exceptions #86

Closed kptLucek closed 8 years ago

kptLucek commented 9 years ago

Basicly:

asimlqt commented 9 years ago

Thanks for taking the time to do this.

This is a huge commit, I'll merge it in the next major release.

kptLucek commented 9 years ago

Updated merge conflicts

kptLucek commented 9 years ago

@asimlqt

asimlqt commented 8 years ago

@kptLucek

I have released a new version of the api (3.0) which includes some fairly big changes, I have also added a few dedicated exceptions.

There are conflicts with this PR and I'm guessing there will be quite a few so unfortunately I'm going to decline this PR. I hope the new version accomplishes what you did with this PR. Feel free to check it out and create a new PR if you still think it's lacking important features.

The reason I left this open for so long was that the changes were too big to merge into a minor update and warranted a major version update.

Thanks