asiniy / faker-russian

Faker russian specific values. INN, OKPO, OGRN et.c.
MIT License
58 stars 6 forks source link

Please add support jruby #6

Open dmitry-ov opened 9 years ago

dmitry-ov commented 9 years ago

✗ gem list | grep faker-russian faker-russian (0.0.6) ✗ ruby -v jruby 1.7.16 (1.9.3p392) 2014-09-25 575b395 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_20-b26 +jit [darwin-x86_64] ✗ irb :001 > require 'faker-russian' LoadError: no such file to load -- faker-russian from org/jruby/RubyKernel.java:1065:in require' from /Users/dmitry/.rvm/rubies/jruby-1.7.16/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:55:inrequire' from (irb):1:in evaluate' from org/jruby/RubyKernel.java:1101:ineval' from org/jruby/RubyKernel.java:1501:in loop' from org/jruby/RubyKernel.java:1264:incatch' from org/jruby/RubyKernel.java:1264:in catch' from /Users/dmitry/.rvm/rubies/jruby-1.7.16/bin/irb:13:in(root)' :002 > require 'faker' => true

asiniy commented 9 years ago

There is a windows... omg. I'm principial ubuntu user. That's why we need the help of windows user.

asiniy commented 9 years ago

Please wait for a few days, I'll try it on ubuntu

dmitry-ov commented 9 years ago

This error is repeated on Mac OS X 10.10.2 jruby 1.7.16 (1.9.3p392) 2014-09-25 575b395 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_20-b26 +jit [darwin-x86_64]

asiniy commented 9 years ago

Same error on linux.

It seems you need go deeper to jruby essentials. I'm not familiar with it. I'll try to find a time to fix it on the weekend.

asiniy commented 9 years ago

You can fasterize the solution by using experience of this issue: http://stackoverflow.com/questions/10833732/jruby-no-such-file-to-load

Just try it! If it works, feel free to modificate .travis.yml and send a pull request.

asiniy commented 9 years ago

Also try to

require 'faker/russian'
dmitry-ov commented 9 years ago

I'm try: require 'faker/russian'. But call Faker::Russian.* return errors

ui git:(develop) ✗ gem list | grep faker faker (1.4.3) faker-russian (0.0.6) ➜ ui git:(develop) ✗ irb
jruby-1.7.16 :001 > require 'faker' => true jruby-1.7.16 :002 > require 'faker/russian' => true jruby-1.7.16 :003 > Faker::Russian.inn NoMethodError: undefined method assert_valid_keys' for {}:Hash from /Users/dmitry/.rvm/gems/jruby-1.7.16@ui/gems/faker-russian-0.0.6/lib/faker/russian/inn.rb:5:ininn' from (irb):3:in evaluate' from org/jruby/RubyKernel.java:1101:ineval' from org/jruby/RubyKernel.java:1501:in loop' from org/jruby/RubyKernel.java:1264:incatch' from org/jruby/RubyKernel.java:1264:in catch' from /Users/dmitry/.rvm/rubies/jruby-1.7.16/bin/irb:13:in(root)' jruby-1.7.16 :004 >

asiniy commented 9 years ago

ok, so you can patch the gem for requiring activesupport special file

dsulimchuk commented 8 years ago

Hi, Issue is actual. Please fix it if you can. Thank a lot!

asiniy commented 8 years ago

Hi! Sorry, I don't have enough time to work on this

vyalekseev commented 5 years ago

Здравствуйте. А будут ли какие-нибудь обновления? Хотя бы чтобы работало на последней версии ruby.

asiniy commented 5 years ago

Will check in a few days

vyalekseev commented 5 years ago

Will check in a few days

Есть новости?=)