asizikov / AsyncSuffix

Asynchronous methods naming checker for ReSharper
http://asizikov.github.io/2015/08/02/async-suffix-resharper-plugin/
MIT License
18 stars 3 forks source link

Add support for Resharper 2017.2 #52

Open pfeigl opened 7 years ago

pfeigl commented 7 years ago

Please add support for Resharper 2017.2 (wave >=9).

Thanks :)

zvirja commented 7 years ago

@asizikov It has been one week since the release 😉 Do you have any plans to add compatibility?

asizikov commented 7 years ago

Yes, I do. Once I'm back from vacation trip I'll address that. Unless someone else wants to take care of that update 🙂 On Mon, 28 Aug 2017 at 09:46, Alex Povar notifications@github.com wrote:

@asizikov https://github.com/asizikov It has been one week since the release 😉 Do you have any plans to add compatibility?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/asizikov/AsyncSuffix/issues/52#issuecomment-325284270, or mute the thread https://github.com/notifications/unsubscribe-auth/AAx_bS9tmPMWTfAYDFz1ssM1NO8V7wiLks5scnBUgaJpZM4O9h4t .

zvirja commented 7 years ago

Thanks for the reply!

Wish you a great vacation :) Do you have some approx. estimations in case nobody else picks that up (e.g. week, month, etc)? :)

asizikov commented 7 years ago

ok, that didn't go as easy as I expected. R# SDK has some breaking changes. I need to spend a bit more time on it.

zvirja commented 7 years ago

Hi.

Do you know whether you have any time in the nearby future to get back to this one? We need this extension to guarantee the quality of our projects and it's a pity that it's missing..

asizikov commented 7 years ago

As I mentioned above, I need to figure out how to deal with the breaking changes in the new SDK. Can't give you any estimates, sorry.

zvirja commented 7 years ago

Could clarify the exact place to look? I also own a R# plugin, so I could potentially take a look..

asizikov commented 7 years ago

the Rename dialog has been rewritten, and the reflection hack which I used before is not working anymore. I didn't spend much time on it yet. Later today I'll publish the WIP branch, any help would be appreciated :)

zvirja commented 7 years ago

Have you published the PR? I cannot find it..

asizikov commented 7 years ago

@zvirja here you go: https://github.com/asizikov/AsyncSuffix/pull/55