asjdf / WebSerialLite

Super lightweight remote serial monitor for ESP8266 & ESP32 (frontend <3k)
GNU General Public License v3.0
59 stars 12 forks source link

Clear command field after sending #18

Open ppeters opened 4 months ago

ppeters commented 4 months ago

I think it would be nice to clear the command 'line' after sending it... by adding:

document.getElementById("command-text").value=""

in the sendCommand function (in the encrypted WebSerialWebPage.h)

To clarify: I use the commend line for multiple purposes and often forget to clear it, which results in concatenating the 'new' command I want to send with the previous one, resulting in something that is not recognized mostly (and IF recognized, not what I wanted probably :-) )

mathieucarbou commented 4 months ago

Fyi you can have a look at my fork, which contains this feature plus a History lookup with up and down keys.

ppeters commented 4 months ago

Mathieu,

Thanks, will definitely look at that. I noticed that ‘your’ WebSerialLite depends on other libraries you also adapted? Does that mean I have to switch to ‘your’ adaptations of those libraries too (ESPAsyncWebServer and AsyncTCP)?

Kind Regards,

Peter

Peter Peters [signature_1300772616] Dr. Ir. P.J.F. Peters Education and Research support Department of Industrial Design

E: @.**@.>

P.O. Box 513, 5600 MB Eindhoven, the Netherlands Visits: Building 3, Atlas, Room 2.120 Secretary: Building 3, Atlas, Room 4.126 Navigation: Den Dolech 2, 5612AZ Eindhovenhttps://maps.apple.com/?address=Den%20Dolech%202,%205612%20AZ%20Eindhoven,%20Netherlands&ll=51.447890,5.485960&q=Den%20Dolech%202 Parcel delivery’s: De Rondom 70, 5612AP Eindhovenhttps://maps.apple.com/?address=De%20Rondom%2070,%205612%20AP%20Eindhoven,%20Netherlands&ll=51.447000,5.494640&q=De%20Rondom%2070 Nothing is impossible. The word itself says it: I’m possible.

From: Mathieu Carbou @.> Date: Monday, 22 April 2024 at 18:56 To: asjdf/WebSerialLite @.> Cc: Peters, Peter @.>, Author @.> Subject: Re: [asjdf/WebSerialLite] Clear command field after sending (Issue #18)

Fyi you can have a look at my fork, which contains this feature plus a History lookup with up and down keys.

— Reply to this email directly, view it on GitHubhttps://github.com/asjdf/WebSerialLite/issues/18#issuecomment-2070229263, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABIHLDUDBBFL6PLRP7XIN5TY6U6MRAVCNFSM6AAAAABGS6AFIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZQGIZDSMRWGM. You are receiving this because you authored the thread.Message ID: @.***>

mathieucarbou commented 4 months ago

It requires ESPAsyncWebServer and AsyncTCP. Any version of them would work, but the original repos are not maintained anymore so I am keeping them alive, fixed a lot of bugs, added Arduino 7 support, and made them compatible with the future Arduino 3 version (ESP-IDF 5.1). Backward compatibility is always maintained.