asjdf / WebSerialLite

Super lightweight remote serial monitor for ESP8266 & ESP32 (frontend <3k)
GNU General Public License v3.0
60 stars 12 forks source link

Inherit from Print instead of overloading print...(), fix crash #9

Closed nullstalgia closed 1 year ago

nullstalgia commented 1 year ago

Stolen from Inspired by https://github.com/ayushsharma82/WebSerial/pull/57 .

Much more generic way of defining the class, which allows for things like printf or inserting items like Wifi.localIP() .

Also, since I replaced all my print statements with this, it would crash when the server wasn't ready. That has been fixed with a quick NULL check.

asjdf commented 1 year ago

Thanks a lot for your PR. I'm currently on vacation but I'll review your PR soon. Thanks again so much!

asjdf commented 1 year ago

Looks like all error are resolved.

Thanks for your PR again.