search

ask / mode

Python AsyncIO Services
Other
240 stars 55 forks source link

Service: Use add_dependecy() to add child dependency in _actually_start #40

Closed nemosupremo closed 5 years ago

nemosupremo commented 5 years ago

.## Description

More information in robinhood/faust#302 as this was uncovered trying to fix robinhood/faust#301

I believe the fact that init_dependencys are directly added to _children instead of using add_dependency is a bug. As is today, dependencies that are added via init_depedency each have its own root beacon, and are unable to properly walk the tree. This causes issues where the CrashingSupervisor isn't able to work as documented because it's unable to fully crash the tree.