ask / mode

Python AsyncIO Services
Other
240 stars 55 forks source link

Faust build fails due to import error in utils/logging.py #52

Closed pbhoiwala closed 4 years ago

pbhoiwala commented 4 years ago

Checklist

Steps to reproduce

I'm using Faust in one of my projects which is using the mode module. The new version for mode (4.1.5) seems to have an import issue in utils/logging.py. This is causing build issues in faust.

Expected behavior

Build to not fail due to import error.

Actual behavior

Build fails due to import error.

Full traceback

Traceback (most recent call last):
server_1          |   File "/usr/local/bin/faust", line 5, in <module>
server_1          |     from faust.cli.faust import cli
server_1          |   File "/usr/local/lib/python3.8/site-packages/faust/cli/__init__.py", line 2, in <module>
server_1          |     from .base import AppCommand, Command, argument, call_command, option
server_1          |   File "/usr/local/lib/python3.8/site-packages/faust/cli/base.py", line 34, in <module>
server_1          |     from mode import Service, ServiceT, Worker
server_1          |   File "/usr/local/lib/python3.8/site-packages/mode/__init__.py", line 126, in __getattr__
server_1          |     module = __import__(
server_1          |   File "/usr/local/lib/python3.8/site-packages/mode/services.py", line 31, in <module>
server_1          |     from .timers import timer_intervals
server_1          |   File "/usr/local/lib/python3.8/site-packages/mode/timers.py", line 5, in <module>
server_1          |     from .utils.logging import get_logger
server_1          |   File "/usr/local/lib/python3.8/site-packages/mode/utils/logging.py", line 47, in <module>
server_1          |     from typing_extensions import Protocol

Versions

Suggestions to fix this

Add typing_extensions in requirements.txt file and rebuild.