Removed survey source models, commands and references - Githubissues

askap-vast / vast-pipeline

This repository holds the code of the Radio Transient detection pipeline for the VAST project.

https://vast-survey.org/vast-pipeline/

MIT License

8 stars 3 forks source link

Removed survey source models, commands and references #538

Closed ajstewart closed 3 years ago

ajstewart commented 3 years ago

Removed Survey, SurveySource and SurveySourceQuerySet from models.
Removed related fields from Source model and crossmatch relation.
Removed importsurvey command and docs page.
Updated schema diagrams.
Removed default_survey from run configuration.
Removed SURVEY_WORKING_DIR from settings and .env files.

Non related minor fixes:

Updated command line docs page for clearpiperun command.
Added type annotation to remove_forced_meas() in forced_extraction.py.
Changelog title changed from Change Log -> Changelog.

Fixes #462.

ajstewart commented 3 years ago

@marxide as we're getting to 1.0.0 it seemed a bit messy that we had all this survey stuff inside when it's not actually used at all, as Sergio pointed out in #462.

I've gone through and removed it all and cleaned up any references and docs.

From my point of view it makes the 1.0.0 release cleaner, but at some point I think you may have had a feature in development that uses this stuff? I guess the beauty is this code isn't really lost, bits can be easily reintroduced if needed. What do you think?