search

askap-vast / vast-pipeline

This repository holds the code of the Radio Transient detection pipeline for the VAST project.
https://vast-survey.org/vast-pipeline/
MIT License
7 stars 3 forks source link

fix test failures #611

Closed marxide closed 2 years ago

marxide commented 2 years ago

Explicitly installing wheel to see if that fixes the test build errors.

marxide commented 2 years ago

It does!

I think the cause was that the latest version of pyvo does not have a wheel uploaded to PyPI. The test runner tries to build one and fails because the environment is missing the wheel package. I guess the test runner environment doesn't include wheel by default, which is strange as every python env I made while trying to debug this issue came with it.

This PR adds wheel to the task runner environment. I decided against adding wheel to the pipeline dependencies as a) I was unable to replicate this outside of the failing build in GitHub Actions, and b) this could be fixed upstream by pyvo uploading some wheels.