search

askap-vast / vast-pipeline

This repository holds the code of the Radio Transient detection pipeline for the VAST project.
https://vast-survey.org/vast-pipeline/
MIT License
7 stars 3 forks source link

Generated source names violate IAU convention #617

Closed marxide closed 2 years ago

marxide commented 2 years ago

The pipeline generates source names based on the coordinates, i.e. VAST JHHMMSS.s±DDMMSS. While converting the source coordinate to a string of the desired precision, it rounds rather than truncates. The IAU convention is to truncate coordinates. See https://cdsweb.u-strasbg.fr/Dic/iau-spec.html#S3.2.1.

Relevant code:

https://github.com/askap-vast/vast-pipeline/blob/1f57760ad7a426049e37fb014b183a02327ea003/vast_pipeline/pipeline/model_generator.py#L58-L62

https://github.com/askap-vast/vast-pipeline/blob/1f57760ad7a426049e37fb014b183a02327ea003/vast_pipeline/utils/utils.py#L116-L179