search

askap-vast / vast-pipeline

This repository holds the code of the Radio Transient detection pipeline for the VAST project.
https://vast-survey.org/vast-pipeline/
MIT License
7 stars 3 forks source link

pipeline.new_sources: New high sigma is actually the new low sigma #713

Open ddobie opened 1 month ago

ddobie commented 1 month ago

See here: https://github.com/askap-vast/vast-pipeline/blob/6209e0d7b1431068869cb917ed6c4e8501aa0c52/vast_pipeline/pipeline/new_sources.py#L431-L442

sort_values automatically sorts in ascending order, meaning that the lowest true_sigma is sorted to the top. Dropping duplicates then drops all but the top entry, i.e. the lowest.

Fix is to add ascending=False to the sort_values call.