search

askap-vast / vast-pipeline

This repository holds the code of the Radio Transient detection pipeline for the VAST project.
https://vast-survey.org/vast-pipeline/
MIT License
8 stars 3 forks source link

refactor pipeline.new_sources.new_sources #732

Open ddobie opened 2 months ago

ddobie commented 2 months ago

In #730 I fixed a memory leak in pipeline.new_sources.new_sources, but the actual implementation was quite hacky.

As commented in the code, the function should be rewritten to reflect the new behaviour of pipeline.new_sources.parallel_get_rms_measurements. The below section should be incorporated into parallel_get_rms_measurements, and parallel_get_rms_measurements should be renamed to something like parallel_get_new_high_sigma.

https://github.com/askap-vast/vast-pipeline/blob/705a815e807eab74e4563274d7a45eab7e3c4396/vast_pipeline/pipeline/new_sources.py#L439-L472