Closed dependabot[bot] closed 2 years ago
numpy v1.22.0 introduced the following bug: https://github.com/numpy/numpy/issues/20699 which was fixed in 1.22.1.
Solution here is to set the numpy dependency to ~1.22.1
.
Can't upgrade to 1.23
as np.asscaler
has been removed that is used extensively somewhere (all tests fail), possibly astropy. Likely solved by #334.
I was bitten by this today. Numpy was updated to 1.23 and various Astropy-related things failed since numpy.asscalar
is gone. astropy>=5.0.1
appears fixed.
I was bitten by this today. Numpy was updated to 1.23 and various Astropy-related things failed since
numpy.asscalar
is gone.astropy>=5.0.1
appears fixed.
At this point you probably want to just (now update) and merge #334. It was held back because I think there was going to be a release but it might as well go in as a maintenance commit and deal with anything it breaks as it's found.
At this point you probably want to just (now update) and merge #334.
I agree -- #334 appears to have a lot of fixes for the issues I'm having, but I'm not fully aware of the things blocking it from being merged so I don't want to do it myself. I'll take what I need to fix the dev branch and put it in a new PR and close this one. It's going well beyond the scope of dependabot now.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Bumps numpy from 1.21.1 to 1.22.0.
Release notes
Sourced from numpy's releases.
... (truncated)
Commits
4adc87d
Merge pull request #20685 from charris/prepare-for-1.22.0-releasefd66547
REL: Prepare for the NumPy 1.22.0 release.125304b
wipc283859
Merge pull request #20682 from charris/backport-204165399c03
Merge pull request #20681 from charris/backport-20954f9c45f8
Merge pull request #20680 from charris/backport-20663794b36f
Update armccompiler.pyd93b14e
Update test_public_api.py7662c07
Update init.py311ab52
Update armccompiler.pyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/askap-vast/vast-tools/network/alerts).