Currently using run_eta_v_analysis with default arguments breaks for the tiles_combined run. The error stems from the binning that is used to create the axis histograms in _plot_eta_v_bokeh and can be traced back to this source that has a negative v_peak.
Handling this within vast-tools is easy (my preference would be to check if there's any negative V values, throw a warning if there is and then remove them. @marxide do you think it would be better to fix this in the pipeline itself? (i.e. there shouldn't be any negative V values in the first place).
Currently using
run_eta_v_analysiswith default arguments breaks for thetiles_combinedrun. The error stems from the binning that is used to create the axis histograms in_plot_eta_v_bokehand can be traced back to this source that has a negativev_peak.Handling this within
vast-toolsis easy (my preference would be to check if there's any negative V values, throw a warning if there is and then remove them. @marxide do you think it would be better to fix this in the pipeline itself? (i.e. there shouldn't be any negative V values in the first place).