askap-vast / vast-tools

A collection of tools that are useful for the VAST project and for exploration of results from the VAST Pipeline.
https://vast-survey.org/vast-tools/
MIT License
8 stars 0 forks source link

Correctly calculate lightcurve y-axis limits for multiple frequencies #566

Closed ddobie closed 2 months ago

ddobie commented 2 months ago

By default my query looks like image but it should look like image

ddobie commented 2 months ago

Problem arises here: https://github.com/askap-vast/vast-tools/blob/34d3b4aa1b30ed09b18c0abb98531eec06b7cbe7/vasttools/source.py#L572-L586

upper_lims is calculated inside the loop over the different frequencies, so it only contains the upper limits for the last frequency.

Solution is to recalculate it outside of the loop.