Closed 3442853561 closed 8 years ago
LGTM, thank you so much :)
There's only one nit, could you please squash these two commits into one, with the meaningful commit message? The meaningful message will help us to understand what we do in each commits quickly.
You can simply do it by git rebase -i HEAD~2, then squash them and modify message. Ref: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages
git rebase -i HEAD~2
LGTM, thank you so much :)
There's only one nit, could you please squash these two commits into one, with the meaningful commit message? The meaningful message will help us to understand what we do in each commits quickly.
You can simply do it by
git rebase -i HEAD~2, then squash them and modify message. Ref: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages