askforalfred / alfred

ALFRED - A Benchmark for Interpreting Grounded Instructions for Everyday Tasks
MIT License
352 stars 77 forks source link

KeyError: 'pddl_params' when running generate_trajectories.py #104

Open wang-sj16 opened 2 years ago

wang-sj16 commented 2 years ago

Hi, I meet the error output KeyError: 'pddl_params' when running generate_trajectories.py, as shown in image below:

image

I was wondering where could be wrong? Thanks!

MohitShridhar commented 2 years ago

@wang-sj16, I am not sure what is happening here. Was generate_trajectories.py somehow modified? It looks like this line isn't being called.

wang-sj16 commented 2 years ago

@MohitShridhar Hi, I didn't modify the code and the running command is python scripts/generate_trajectories.py --save_path data/new_trajs --in_parallel --debug --num_threads 1

wang-sj16 commented 2 years ago

@MohitShridhar found the bug. In this line, it should use import constants rather than import gen.constants as constants, latter will generate a new constants instance with no initilization.

MohitShridhar commented 2 years ago

oh thanks @wang-sj16 for investigating this. I'll try it out and merge into master soon.