askforalfred / alfred

ALFRED - A Benchmark for Interpreting Grounded Instructions for Everyday Tasks
MIT License
352 stars 77 forks source link

generate_trajectories getting stuck #120

Closed RishiHazra closed 2 years ago

RishiHazra commented 2 years ago

Hi @MohitShridhar

I'm trying to generate new trajectories. However, the generation always gets stuck after resetting the environment: Here is output when I run it:

Force Unsave Data: False
Loaded 0 known failed tuples
Found path: ...
Mono path[0] = ...
Mono config path = ...
Preloaded 'ScreenSelector.so'
Display 0 '0': 1920x1200 (primary device).
Logging to ...
ThorEnv started.
###################################

Successes: 
Empty DataFrame
Columns: [goal, pickup, movable, receptacle, scene]
Index: []

##################################
('pick_and_place_with_movable_recep', 'Fork', 'Cup', 'DiningTable', 17)
sampled tuple: ('pick_and_place_with_movable_recep', 'Fork', 'Cup', 'DiningTable', 17)
PDDLGoalType: pick_and_place_with_movable_recep
Saving images to: dataset/new_trajectories/pick_and_place_with_movable_recep-Fork-Cup-DiningTable-17/trial_T20220806_035502_492636/raw_images/
Resetting ThorEnv

I have installed the exact version of AI2Thor as mentioned in the requirements.txt file. After debugging for a while, I was able to narrow it down to https://github.com/askforalfred/alfred/blob/1898b83547b589b8635737929e04ee4f2f404177/env/thor_env.py#L66 However, I'm unable to debug it. Would appreciate some help here.

Thanks in advance !!!

askforalfred commented 2 years ago

Can you check the error in "/home/rishihazra/.config/unity3d/Allen Institute for Artificial Intelligence/AI2-Thor/Player.log" ?

On Fri, Aug 5, 2022 at 7:09 PM 'RishiHazra' via askforalfred < @.***> wrote:

Hi @MohitShridhar https://github.com/MohitShridhar

I'm trying to generate new trajectories. However, the generation always gets stuck after resetting the environment: Here is output when I run it:

`Force Unsave Data: False Loaded 0 known failed tuples Found path: /home/rishihazra/.ai2thor/releases/thor-201909061227-Linux64/thor-201909061227-Linux64 Mono path[0] = '/home/rishihazra/.ai2thor/releases/thor-201909061227-Linux64/thor-201909061227-Linux64_Data/Managed' Mono config path = '/home/rishihazra/.ai2thor/releases/thor-201909061227-Linux64/thor-201909061227-Linux64_Data/Mono/etc' Preloaded 'ScreenSelector.so' Display 0 '0': 1920x1200 (primary device). Logging to /home/rishihazra/.config/unity3d/Allen Institute for Artificial Intelligence/AI2-Thor/Player.log ThorEnv started. ###################################

Successes: Empty DataFrame Columns: [goal, pickup, movable, receptacle, scene] Index: []

################################## ('pick_and_place_with_movable_recep', 'Fork', 'Cup', 'DiningTable', 17) sampled tuple: ('pick_and_place_with_movable_recep', 'Fork', 'Cup', 'DiningTable', 17) PDDLGoalType: pick_and_place_with_movable_recep Saving images to: dataset/new_trajectories/pick_and_place_with_movable_recep-Fork-Cup-DiningTable-17/trial_T20220806_035502_492636/raw_images/ Resetting ThorEnv ` I have installed the exact version of AI2Thor as mentioned in the requirements.txt file. After debugging for a while, I was able to narrow it down to https://github.com/askforalfred/alfred/blob/1898b83547b589b8635737929e04ee4f2f404177/env/thor_env.py#L66 However, I'm unable to debug it. Would appreciate some help here.

Thanks in advance !!!

— Reply to this email directly, view it on GitHub https://github.com/askforalfred/alfred/issues/120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3HWRC53X6KYMW4XYGQ4RTVXXCNLANCNFSM55XYBTVA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- You received this message because you are subscribed to the Google Groups "askforalfred" group. To unsubscribe from this group and stop receiving emails from it, send an email to @. To post to this group, send email to @. To view this discussion on the web visit https://groups.google.com/d/msgid/askforalfred/askforalfred/alfred/issues/120%40github.com https://groups.google.com/d/msgid/askforalfred/askforalfred/alfred/issues/120%40github.com?utm_medium=email&utm_source=footer . For more options, visit https://groups.google.com/d/optout.

RishiHazra commented 2 years ago
Fallback handler could not load library /home/rishihazra/.ai2thor/releases/thor-Linux64-bdcefe04c17bef073ecfe3d90786e84740f7addf/thor-Linux64-bdcefe04c17bef073ecfe3d90786e84740f7addf_Data/Mono/libadvapi32.dll.so
Fallback handler could not load library /home/rishihazra/.ai2thor/releases/thor-Linux64-bdcefe04c17bef073ecfe3d90786e84740f7addf/thor-Linux64-bdcefe04c17bef073ecfe3d90786e84740f7addf_Data/Mono/libadvapi32.dll
askforalfred commented 2 years ago

That particular error feels outside the scope of the ALFRED codebase and is instead within the AI2-THOR installation.

On Fri, Aug 5, 2022 at 7:27 PM 'RishiHazra' via askforalfred < @.***> wrote:

Fallback handler could not load library /home/rishihazra/.ai2thor/releases/thor-Linux64-bdcefe04c17bef073ecfe3d90786e84740f7addf/thor-Linux64-bdcefe04c17bef073ecfe3d90786e84740f7addf_Data/Mono/libadvapi32.dll.so Fallback handler could not load library /home/rishihazra/.ai2thor/releases/thor-Linux64-bdcefe04c17bef073ecfe3d90786e84740f7addf/thor-Linux64-bdcefe04c17bef073ecfe3d90786e84740f7addf_Data/Mono/libadvapi32.dll

— Reply to this email directly, view it on GitHub https://github.com/askforalfred/alfred/issues/120#issuecomment-1207129093, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3HWRFDSGFKECED4QJT7WDVXXEPLANCNFSM55XYBTVA . You are receiving this because you commented.Message ID: @.***>

-- You received this message because you are subscribed to the Google Groups "askforalfred" group. To unsubscribe from this group and stop receiving emails from it, send an email to @. To post to this group, send email to @. To view this discussion on the web visit https://groups.google.com/d/msgid/askforalfred/askforalfred/alfred/issues/120/1207129093%40github.com https://groups.google.com/d/msgid/askforalfred/askforalfred/alfred/issues/120/1207129093%40github.com?utm_medium=email&utm_source=footer . For more options, visit https://groups.google.com/d/optout.

RishiHazra commented 2 years ago

I suspected that. Not sure why though. Anyways, appreciate the quick response. Thanks!

YaqiXie commented 1 year ago

@RishiHazra Did you solve the problem? I got the same issue Orz

RishiHazra commented 1 year ago

@RishiHazra Did you solve the problem? I got the same issue Orz

@YaqiXie Hi, the problem was mainly because of the torch module. You could try two things: The AI2Thor recommended version + older version of torch (https://github.com/alexpashevich/E.T./issues/8) or upgrading the AI2Thor package + newer torch version

YaqiXie commented 1 year ago

@RishiHazra I tried to use the recommended version torch 1.1.0 and torchvision 0.3.0. But it still doesn't work. And even tried a virtual env without torch at all. But I still run into the same issue Orz No idea why.

RishiHazra commented 1 year ago

@RishiHazra I tried to use the recommended version torch 1.1.0 and torchvision 0.3.0. But it still doesn't work. And even tried a virtual env without torch at all. But I still run into the same issue Orz No idea why.

@YaqiXie: In my case, I had to upgrade the AI2Thor version (ai2thor~=4.2.0) to be compatible with my torch version (torch==1.11.0+cu113 torchvision==0.12.0+cu113 torchaudio==0.11.0). This could depend on your system configuration -- however, I have been able to make it work on different systems without any issues. Note that you might have to make slight changes in the ALFRED code too since it is based on an older version of AI2Thor (2.1.0). I'd be happy to help with that.

Also, see if you can find something useful in another similar issue (https://github.com/alexpashevich/E.T./issues/8) if you want to keep using the recommended version.

YaqiXie commented 1 year ago

@RishiHazra Hi Rishi, Yep, a later version of AI2THOR works for me. How did you modify the ALFRED code? The action API seems different. Thank you a lot for the help!

RishiHazra commented 1 year ago

@RishiHazra Hi Rishi, Yep, a later version of AI2THOR works for me. How did you modify the ALFRED code? The action API seems different. Thank you a lot for the help!

@YaqiXie Hi Yaqi, while I'm unable to share my current code here, I can give you some pointers to help modify the code. Most of the modifications that I made were taken from this repository (https://github.com/jiasenlu/alfred) which is modified to be compatible with AI2THOR 2.5.1. If I remember correctly, these modifications worked even for AI2THOR 4.2.0. There were additional minor changes that I had to make in the object poses (see this). I'd also recommend you look into the AI2THOR documentation of actions to get a clear understanding of what you might need. Feel free to reach out at (rishi.hazra@oru.se) in case you run into issues.

YaqiXie commented 1 year ago

@RishiHazra Hi Rishi, Thank you very much :)