askmike / gekko

A bitcoin trading bot written in node - https://gekko.wizb.it/
MIT License
10.08k stars 3.93k forks source link

docker-compose.yml misconfiguration #2749

Closed hgouveia closed 5 years ago

hgouveia commented 5 years ago

I'm submitting a ... [X ] bug report [ ] question about the decisions made in the repository

Action taken

docker-compose build
docker-compose up -d

Expected result Mount config.js correctly

Actual result (unexpected outcome) config.js is mounted as a folder if the file doesn't exist and if you made a copy sample-config.js as config.js and run docker-compose again you will get an error since is trying to mount a folder

Other information in docker-compose, when you need to mount a file, you need to provided the absolute path, if you put a relative path it will assume is a folder , in other to fix it, you just need to replace in docker-compose.yml , this line

- ./config.js:/usr/src/app/config.js to - ${PWD}/config.js:/usr/src/app/config.js

and would be very helpful if is mentioned in the Docker instruction that you need to make a copy sample-config.js as config.js before

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me.