askmike / gekko

A bitcoin trading bot written in node - https://gekko.wizb.it/
MIT License
10.05k stars 3.95k forks source link

QA and merge commits from other forks #306

Closed bugron closed 8 years ago

bugron commented 8 years ago

I went through all 329 forks and found some of them with extra commits that may be useful but are not included in this repo. Check the appropriate checkbox after merging commits of a fork. Look for any changes in all branches. Here is the list of those forks.

In addition to https://github.com/askmike/gekko/issues/216.

askmike commented 8 years ago

(Is this an automated issue?)

I'll go through this list, but I am pretty sure most of this commits were made on top of the legacy codebase (currently still master branch).

bugron commented 8 years ago

No, it's not. That took me 2 hours.

askmike commented 8 years ago

Woow thanks a bunch! I was thinking about doing something similar but the amount of forks (329) kept me away. This list is definitely manageable and I should be able to spot interesting commits quickly (probably bug fixes, new exchanges and new plugins). I'll get around this soon.

askmike commented 8 years ago

Went through most of them and definitely found some gems in there :)

bugron commented 8 years ago

@askmike that's awesome! Mike, I wrote a basic bx.in.th exchange API wrapper based on your btcchina package. I have their public API working but I can't test their private API. I'll push it later to GitHub, would you mind to check it out?

askmike commented 8 years ago

Great! I'll check it out later (going to bed now). You can also publish it to npm if you want.

@askmike https://github.com/askmike that's awesome! Mike, I wrote a basic bx.in.th exchange API wrapper based on your btcchina package. I have their public API working but I can't test their private API. I'll push it later to GitHub, would you mind to check it out?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/askmike/gekko/issues/306#issuecomment-224434664, or mute the thread https://github.com/notifications/unsubscribe/AA7MD5SvHkTEnXWCtMGcC8DYhvKAwnshks5qJfFygaJpZM4Iu1Jt .

bugron commented 8 years ago

OK, pushed to GitHub, here is the repo https://github.com/bugron/bitexthai, I've published it to npm too, npm i bitexthai.

Piega commented 8 years ago

Check this repo for other api or implement XChange lib in gekko: https://github.com/timmolter/XChange

askmike commented 8 years ago

@Piega that looks great, I'll keep an eye on that. Unfortunately it's a java project which Gekko can't easily use..

valeriominetti commented 8 years ago

https://github.com/kuzetsa/gekko has nice additions to cexio.js now underlying api is not restricted to ghs/btc trade and he parametrized it better removing some hardcoded strings. his exchanges.js definition for cexio is still outdated but just adding the right pairs seems to work fine ( tested on gekko stable).

askmike commented 8 years ago

done!