search

askmrsinh / touchpad-indicator

Touchpad management GNOME Shell Extension.
https://extensions.gnome.org/extension/131/touchpad-indicator/
GNU General Public License v2.0
83 stars 20 forks source link

GS 3.32 - TypeError: PopupMenu.PopupSwitchMenuItem.prototype._init is undefined #34

Closed luca-viggiani closed 4 years ago

luca-viggiani commented 5 years ago

Hi, I'm testing lates version from GitHub on GS 3.32 on Arch Linux and I get the following error (as shown by looking-glass):

PopupMenu.PopupSwitchMenuItem.prototype._init is undefined

Here are my debug info:

Versione di GNOME shell: 3.32.0
Versione di Touchpad Indicator: 32
Touchpad: SynPS/2 Synaptics TouchPad | DLL075B:01 06CB:76AF Touchpad
Synclient: Non trovato o utilizzato nel sistema.
Xinput: Not found on your system.
Switch Method: Gconf

I'm on a Wayland session Cheers

askmrsinh commented 5 years ago

There are a number of issues when using the extension on Wayland. Have you tried it on the X system as well? Does it give the same error?

I haven't fully tested support for gnome shell 3.32. I really wanted the extension version to match the shell release version.

luca-viggiani commented 5 years ago

Not yet, I'm going to test it now. However, I've been using the extension on Wayland and Gnome 3.30 without any problems for long time.

luca-viggiani commented 5 years ago

Ok tested on X11 right now, same error. :(

askmrsinh commented 5 years ago

Okay, it's due to the recent changes introduced in https://github.com/GNOME/gnome-shell/commit/bacfdbbb0338b94295c64093523bca7ba8d5c5ca. Will try to make the required changes over the weekend. Thank you for reporting!

luca-viggiani commented 5 years ago

Great thanks!

Il lun 18 mar 2019, 19:58 Ashesh Singh notifications@github.com ha scritto:

Okay, it's due to the recent changes introduced in GNOME/gnome-shell@ bacfdbb https://github.com/GNOME/gnome-shell/commit/bacfdbbb0338b94295c64093523bca7ba8d5c5ca . Will try to make the required changes over the weekend. Thank you for reporting!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/user501254/TouchpadIndicator/issues/34#issuecomment-474055888, or mute the thread https://github.com/notifications/unsubscribe-auth/AX4EivaprdgwJZzSP3wZVbcM5G6vUrGxks5vX-G-gaJpZM4b5gl2 .

askmrsinh commented 5 years ago

Adding details of the error.

https://github.com/user501254/TouchpadIndicator/blob/af6fb8a61000f8a5e9bb4032819f46fbb8abcfb0/extension.js#L257

Apr 04 14:33:22 ubuntu gnome-shell[1827]: JS WARNING: [/home/ubuntu/.local/share/gnome-shell/extensions/touchpad-indicator@orangeshirt/extension.js 257]: reference to undefined property "_init"
Apr 04 14:33:22 ubuntu gnome-shell[1827]: Extension "touchpad-indicator@orangeshirt" had error: TypeError: PopupMenu.PopupSwitchMenuItem.prototype._init is undefined
askmrsinh commented 5 years ago

Hi, just wanted to update you that all Lang.Class definitions will have to be changed to the new ES6 syntax as a result of upstream changes. This will take considerably more time to accomplish.

askmrsinh commented 5 years ago

@luca-viggiani Please check if the current master works for you. Let me know in case of any issues.

luca-viggiani commented 5 years ago

Thanks!

Luca Viggiani CTO and QMSGrammelot Srl Via Copernico, 38 20125 Milano

T: +39 02 89075413 F: +39 02 32066978 M: +39 340 3627802 Skype: gorgonilla Please consider the environment before printing this e-mail. This email and any attachments are confidential to the intended recipient and may also be privileged. If you are not the intended recipient please delete it from your system and notify the sender. You should not copy it or use it for any purpose nor disclose or distribute its contents to any other person. Any improper use of this email and its attachments will lead to the person responsible having to deal with all the associated civil and criminal consequences of their actions (EU Regulation 2016/679). The sender shall not be liable for the improper or incomplete transmission of the information contained in this communication nor for any delay in its receipt or damage to your system. The sender does not guarantee that the integrity of this communication has been maintained nor that this communication is free of viruses, interceptions or interference. About GDPR: the recipient receives this e-mail because gave us his data personally or through a digital media expressing his explicit authorization to use them. We encourage you to review our Privacy Policy and Data Protection Policy https://www.grammelot.eu/GDPR_PrivacyPolicy.pdf. If you have any questions, please contact us at privacy@grammelot.eu.

Il giorno dom 23 giu 2019 alle ore 14:25 Ashesh Singh < notifications@github.com> ha scritto:

@luca-viggiani https://github.com/luca-viggiani Please check if the current master https://github.com/user501254/TouchpadIndicator/tree/master works for you. Let me know in case of any issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/user501254/TouchpadIndicator/issues/34?email_source=notifications&email_token=AF7AJCVFMAZIOUEJKVAYM6DP35TTZA5CNFSM4G7GBF3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYK5G4Q#issuecomment-504746866, or mute the thread https://github.com/notifications/unsubscribe-auth/AF7AJCVGPHEFLWR6PHRFSG3P35TTZANCNFSM4G7GBF3A .

askmrsinh commented 4 years ago

Fixed under v33.