search

askonomm / shh

A CLI password manager designed for efficiency.
MIT License
22 stars 1 forks source link

Implement tags/categories #11

Closed askonomm closed 2 years ago

askonomm commented 2 years ago

At one point doing a simple shh list is not going to be very helpful as you have hundreds of passwords, so it would be cool to create a tags or categories system. Perhaps something like asking for a tag up front when creating a password and ability to change tag with shh change {name} as well as list by a tag when there are tags via shh list.

AbhinavOmprakash commented 2 years ago

Are you working on this? If not, I'd like to work on it.

askonomm commented 2 years ago

I haven't had the time to start on it so if you want it's all yours :)

AbhinavOmprakash commented 2 years ago

Do you want to allow different tags to have the same password name? kinda like namespaced passwords.

for e.g tag "work" name "email" tag "home" name "email"

Or do we force unique password names?

I have created a "default" tag so it won't affect people that choose to not opt into using tags. and find, create and all other functions shouldn't affect them.

askonomm commented 2 years ago

Ooh, good question! I think, for usability, having work.email and home.email would be best, but the way Shh is currently built is to rely on :name alone at everything, so that would mean some refactoring to check if a password has a tag, and then combine the tag and a name into a identifier. Then shh change email would turn into shh change work.email or whatever syntax would be best, not sure. Go with whatever you think is best, I have no strong opinion on this.

AbhinavOmprakash commented 2 years ago

Whether or not we implement namespaced passwords, the find by name part will have to be refactored.

As you said, it is good for usability, and I agree. I'll work on that.

Also, to keep Things uniform with clojure's syntax. Something like work/email would look better than work.email

On Tue, Oct 26, 2021, 3:01 PM Asko Nõmm @.***> wrote:

Ooh, good question! I think, for usability, having work.email and home.email would be best, but the way Shh is currently built is to rely on :name alone at everything, so that would mean some refactoring to check if a password has a tag, and then combine the tag and a name into a identifier. Then shh change email would turn into shh change work.email or whatever syntax would be best, not sure. Go with whatever you think is best, I have no strong opinion on this.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/askonomm/shh/issues/11#issuecomment-951756175, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANKKURBSQHH5S4QM4VZDWH3UIZYNNANCNFSM5GRZGGWA .

askonomm commented 2 years ago

Yup, makes sense to me!