Fix to get threshold 0 working as documented

askorama / orama

🌌 Fast, dependency-free, full-text and vector search engine with typo tolerance, filters, facets, stemming, and more. Works with any JavaScript runtime, browser, server, service!

https://docs.askorama.ai

Other

8.27k stars 273 forks source link

Fix to get threshold 0 working as documented #644

Closed valstu closed 4 months ago

valstu commented 4 months ago

This PR is a suggestion to fix #642. Instead of two sets, one for token counts and one for scores we combine them into a single set. Now when sorting the list it guarantees that they're in right order. Read further information and try the test case of a bug on Replit, mentioned in the issue #642

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
orama-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 22, 2024 3:56pm

valstu commented 4 months ago

Let me know what you think

micheleriva commented 4 months ago

@allevo can you please take a look at this?

allevo commented 4 months ago

I put a comment, but generally, it is ok for me! Thanks!

valstu commented 4 months ago

I put a comment, but generally, it is ok for me! Thanks!

Added changes, thanks!

micheleriva commented 4 months ago

Thank you @valstu , will release this in a few hours.