search

askorama / orama

🌌 Fast, dependency-free, full-text and vector search engine with typo tolerance, filters, facets, stemming, and more. Works with any JavaScript runtime, browser, server, service!
https://docs.askorama.ai
Other
8.27k stars 273 forks source link

fix(hybrid search results): fixed hybrid search by removing redundant… #731

Closed rajeshj11 closed 2 weeks ago

rajeshj11 commented 3 weeks ago

/claim #730 /fixes #730

… slicing before filtering

results were sliced and then filtered, causing incorrect document return and an upper-bounded count value. Now, filtering is done first to ensure accurate total count and correct document retrieval.

demo video: https://www.loom.com/share/63cc6cfee37c434596d79750977d5dff

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-docs ❌ Failed (Inspect) Jun 10, 2024 1:59pm
micheleriva commented 3 weeks ago

Hi, can you please add some tests? Thank you

rajeshj11 commented 3 weeks ago

Hi, can you please add some tests? Thank you

In project, we already has test cases. packages/orama/tests/search.hybrid.test.ts

rajeshj11 commented 3 weeks ago

Hi, can you please add some tests? Thank you

Added the test cases. can you please check now

rajeshj11 commented 3 weeks ago

@micheleriva are there any other changes required from my side to proceed further? let me know if needed.

rajeshj11 commented 2 weeks ago

@micheleriva Hey, could you please review the PR changes? if any changes are needed please let me know

rajeshj11 commented 2 weeks ago

@nicolastoulemont Hey, reverted the test cases to their original values. can you please check now

rajeshj11 commented 2 weeks ago

@micheleriva I wanted to follow up on the latest changes, where I’ve addressed all the comments and made the requested changes. Could you please take a moment to review the updates? Your feedback would be greatly appreciated.

SaraVieira commented 2 weeks ago

Hey!

Sorry for the delay on getting back to you on this, this looks great! Merging it now

rajeshj11 commented 2 weeks ago

@SaraVieira Ideally Post merge bounty should be rewarded. However, I am not able to see the reward label. Is this issue from algora pbc bot?

micheleriva commented 2 weeks ago

Hi @rajeshj11 please give us one day to process this.

rajeshj11 commented 2 weeks ago

Hi @rajeshj11 please give us one day to process this.

yeah sure, no rush. Just want to know where it is blocked.

rajeshj11 commented 1 week ago

@micheleriva may I know the status.