askovpen / node-fidonet-mailer-binkp-crypt

GNU General Public License v2.0
4 stars 1 forks source link

v0.12 is still broken #3

Closed bnoordhuis closed 9 years ago

bnoordhuis commented 9 years ago

@askovpen The fix from 58ff190 is not enough:

  CXX(target) Release/obj.target/crypt/crypt.o
In file included from ../crypt.cc:4:0:
/home/bnoordhuis/src/v1.x/src/node_object_wrap.h: In instantiation of 'static T* node::ObjectWrap::Unwrap(v8::Handle<v8::Object>) [with T = BinkpCrypt]':
../crypt.cc:105:62:   required from here
/home/bnoordhuis/src/v1.x/src/node_object_wrap.h:34:32: error: 'node::ObjectWrap' is an inaccessible base of 'BinkpCrypt'
     return static_cast<T*>(wrap);
                                ^
/home/bnoordhuis/src/v1.x/src/node_object_wrap.h: In static member function 'static T* node::ObjectWrap::Unwrap(v8::Handle<v8::Object>) [with T = BinkpCrypt]':
/home/bnoordhuis/src/v1.x/src/node_object_wrap.h:35:3: warning: control reaches end of non-void function [-Wreturn-type]
   }
   ^
crypt.target.mk:86: recipe for target 'Release/obj.target/crypt/crypt.o' failed
make: *** [Release/obj.target/crypt/crypt.o] Error 1
make: Leaving directory '/home/bnoordhuis/src/strongloop/node-fidonet-mailer-binkp-crypt/build'

This line:

class BinkpCrypt : node::ObjectWrap {

Should read:

class BinkpCrypt : public node::ObjectWrap {
askovpen commented 9 years ago

yet fixed