askvortsov1 / flarum-pwa

Progressive Web App support for Flarum
MIT License
34 stars 12 forks source link

Allow no BG color, update dependencies and config #42

Closed rafaucau closed 1 year ago

rafaucau commented 2 years ago

resolves: #41

image

iamdarkle commented 1 year ago

Hey rafaucau great effort with this! I was just thinking about upgrading this extension to Webpack 5 and I came across your PR, I have built the js and have been testing it, so far so good.

I noticed that although now it allows you to leave the color blank, the meta theme-color tag that Flarum adds by default still overwrites and applies the main color of the forum, anyway that has nothing to do with this extension, I saw this thread about changing the theme-color https://discuss.flarum.org/d/20524-changing-the-meta-theme-color/ but I don't know if there is a way to remove it directly

askvortsov1 commented 1 year ago

Thanks! Implementing most of these separately with some other changes