search

aslafy-z / helm-git

Helm Plugin - Install Helm Charts strait from Git repositories
Apache License 2.0
287 stars 46 forks source link

fix(helm-git): multiple fixes #262

Closed GMartinez-Sisti closed 1 month ago

GMartinez-Sisti commented 1 year ago

Why

I was trying this awesome plugin, but found some issues with the way I wanted to use it. I want to be able to use packaged helm charts from a branch, the charts and index.yaml might be in the root folder of the repository and this was not allowed.

Also had to set the url to git+ssh://git@github.com/org/repository/path/package-x.x.x.tgz?ref=branch&sparse=0&depupdate=1&package=0 in index.yaml on all the packages for this work.

What

  1. add trace: makes it easier to troubleshoot
  2. allow using repository root folder: there was an assumption that there would be a path with @
  3. ensure we have the latest from ref: when using HELM_GIT_REPO_CACHE the branch wouldn't be updated, probably the initial intention was to only use tags
  4. lint file: shellcheck
aslafy-z commented 1 year ago

Thank you for the contribution 🙏 I'm currently on vacation, I will take a look once back in a few days.

GMartinez-Sisti commented 1 year ago

Thank you for the contribution 🙏 I'm currently on vacation, I will take a look once back in a few days.

Thank you for the feedback. Enjoy your vacations! 🌴

GMartinez-Sisti commented 8 months ago

Ping 👼

aslafy-z commented 7 months ago

Hey there! Sorry for the long delay and thank you for pinging again! This looks good! Can you please add a test to validate that we can now refer to the root without using @ and that it still works with the old way? Thank you!

aslafy-z commented 4 months ago

@GMartinez-Sisti hey, I would like to merge this PR, let me know if you're able to do the required change. I may take the PR over if not.

GMartinez-Sisti commented 4 months ago

@GMartinez-Sisti hey, I would like to merge this PR, let me know if you're able to do the required change. I may take the PR over if not.

Hi @aslafy-z, sorry for not picking this up earlier! I already lost context for this PR 😬 Feel free to take it 😄

aslafy-z commented 4 months ago

add trace: makes it easier to troubleshoot

Ported with https://github.com/aslafy-z/helm-git/pull/266

allow using repository root folder: there was an assumption that there would be a path with @

~See #267, not sure how it would behave with GitLab multi level hierarchy for instance. Will keep as a draft until I find a solution.~ Implemented with #284.

ensure we have the latest from ref: when using HELM_GIT_REPO_CACHE the branch wouldn't be updated, probably the initial intention was to only use tags

Wouldn't this defeat the cache? What would be the right time to refresh for you? Tracked at #292.

lint file: shellcheck

Ported with #268. It would be a nice to have as a pre-commit step/in the ci, issue at #288.

Edit 2024/07/09: Updated

aslafy-z commented 1 month ago

Thank you for your work on this PR. Every bits are now either implemented or tracked within new issues. See my previous comment: https://github.com/aslafy-z/helm-git/pull/262#issuecomment-2050227998.