search

aslagle / reactive-table

A reactive table designed for Meteor
https://atmospherejs.com/aslagle/reactive-table
Other
328 stars 137 forks source link

There are multiple templates named 'leaderboard' #482

Open tab00 opened 7 years ago

tab00 commented 7 years ago

After updating to 0.8.43 I saw the above error in the console, and the app doesn't load.

I downgraded to 0.8.42 and my app is working again.

Please fix this problem so that we can use the latest version.

Thank you.

aslagle commented 7 years ago

Sorry about that. The only thing I changed in 0.8.43 was the dependency on underscore to fix #481, and I don't see how that would cause this problem. It's commit c81598ab7b971da5baa3b7ee0ca714d123cf80ca.

Maybe meteor publish did something weird. In that case it wouldn't help to revert the change and publish again. Any ideas?

harrisonhunter commented 7 years ago

I also saw this behavior and was unable to build render my application correctly because of issues with the leaderboard template: https://www.dropbox.com/s/q59392gj6zzv6cf/Screenshot%202017-11-19%2023.04.18.png?dl=0 reverting made it work normally

aslagle commented 7 years ago

Weird. The leaderboard template is used in examples but they're not supposed to be part of the package. I published with a newer version of meteor than I've used in the past so maybe it included those files even though they're not listed in package.js. I haven't been keeping up with the changes to meteor.

rmuratov commented 7 years ago

Can confirm, same issue with multiple templates with one name. Switched back to 0.8.42, everything works fine. Maybe changes in build process.

EDIT Having no other ideas I tried replacing old api.add_files with api.addFiles etc (as suggested in docs). Without any success. For now I ended up with removing the whole examples dir.

@s7dhansh thought the same about eager loading, but what's the point of adding files explicitly then...

s7dhansh commented 7 years ago

I think the leaderboard template is being compiled multiple times as it is not in imports directory. The new meteor version for packages would have become more in sync with the normal apps, by eagerly loading everything in non-imports.

aslagle commented 7 years ago

I published 0.8.44 with an older version of meteor to see if it fixes the problem. I didn't make any other changes. Let me know if it works.

s7dhansh commented 7 years ago

Yes it does. The meteor shell issue is also fixed.

rmuratov commented 7 years ago

Yes, that worked for me as well. Thanks!