aslams2020 / Stark-Tech-Portfolio

A tribute to Iron Man! This portfolio website is inspired by the iconic character Tony Stark and is designed to showcase various projects, skills, and experiences in a sleek and modern interface, reflecting the high-tech and innovative spirit of Stark Industries.
https://stark-tech-portfolio.vercel.app
MIT License
63 stars 115 forks source link

Added Blogs Page | Issue #255 #295

Closed Shariq2003 closed 2 weeks ago

Shariq2003 commented 3 weeks ago

fix #255

I have added the Blogs Page that contain the Blogs,

Eg.

  1. Title: The Evolution of Iron Man: From Comic to Cinematic Icon
  1. Title: Women of Marvel: Breaking Barriers in the MCU
  1. Title: The Infinity Saga: A Retrospective on the MCU's Biggest Arcs
  1. Title: The Future of the MCU: What’s Next for Marvel?

https://github.com/user-attachments/assets/fe541128-0420-44fa-bae2-81d9aa559422

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stark-tech-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 11:14pm
Shariq2003 commented 3 weeks ago

The images are not matching with the blog title.. Also the layout, design and everything is the same as "Comics" page. It should be different as these are blogs page.

Add 6 blogs

Please add relevant images to the blogs according to their title, you can refer similar below example image

okay

aslams2020 commented 2 weeks ago

@Shariq2003 Any updates ?

Shariq2003 commented 2 weeks ago

@aslams2020 sir, I will raise the PR by tonight

Shariq2003 commented 2 weeks ago

PLease make a new PR @Shariq2003

okay @aslams2020 sir Please allow me sometime

aslams2020 commented 2 weeks ago

Yeah Sure.

Shariq2003 commented 2 weeks ago

Yeah Sure.

Thanks alot sir

Shariq2003 commented 2 weeks ago

@aslams2020 sir, Now I have added the 6 Blogs referred from this website LINK Also, make the page look like a Blogs Page with the theme conservation of the website.

https://github.com/user-attachments/assets/8c5f76e2-d264-4a1c-a0f6-157aa0eaee05

Shariq2003 commented 2 weeks ago

@aslams2020 sir, Please review this PR on priority because if you merge any other PR, than this PR will face conflict in the files, as I have also change the navbar for navigation to this page, in multiple pages.

Shariq2003 commented 2 weeks ago

@aslams2020 sir, but new page should be of level 3 Am right ?

aslams2020 commented 2 weeks ago

Hi @Shariq2003, Creating a new Page does not actually guarentee a level3. As it is not dependant on number of lines.

i reviewed -

I hope you understand, Why i gave level2 for it.

happy coding!

Shariq2003 commented 2 weeks ago

Hi @Shariq2003, Creating a new Page does not actually guarentee a level3. As it is not dependant on number of lines.

i reviewed -

  • In the Blogs page, The navbar and footer are integrated from the homepage (as it should be)
  • The layout of the cards and the styling of them is not newly styled as it is similar to movies and comics pages. Which make no difference in creating a different kind of development idea.
  • Also the page is not responsive

I hope you understand, Why i gave level2 for it.

happy coding!

@aslams2020 sir Okay what if I make it responsive in my new PR on which you don't have to add any level, just make this PR to level 3, after merging that PR

Fine ?

aslams2020 commented 2 weeks ago

I can give that issue's PR Level1.

As this current PR will be a even then a level2, because of the 2nd point. As it is crucial to showcase our developer ideas in whatever work we do.

If you wish to make it responsive, please create an issue first.

Shariq2003 commented 2 weeks ago

I can give that issue's PR Level1.

As this current PR will be a even then a level2, because of the 2nd point. As it is crucial to showcase our developer ideas in whatever work we do.

If you wish to make it responsive, please create an issue first.

Yes sir, I just applied the same styling to match the theme of the website, nothing else.

Okay no problem sir, raising an issue for responsiveness