Closed Shariq2003 closed 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
stark-tech-portfolio | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 2, 2024 11:14pm |
The images are not matching with the blog title.. Also the layout, design and everything is the same as "Comics" page. It should be different as these are blogs page.
Add 6 blogs
Please add relevant images to the blogs according to their title, you can refer similar below example
okay
@Shariq2003 Any updates ?
@aslams2020 sir, I will raise the PR by tonight
PLease make a new PR @Shariq2003
okay @aslams2020 sir Please allow me sometime
Yeah Sure.
Yeah Sure.
Thanks alot sir
@aslams2020 sir, Now I have added the 6 Blogs referred from this website LINK Also, make the page look like a Blogs Page with the theme conservation of the website.
https://github.com/user-attachments/assets/8c5f76e2-d264-4a1c-a0f6-157aa0eaee05
@aslams2020 sir, Please review this PR on priority because if you merge any other PR, than this PR will face conflict in the files, as I have also change the navbar for navigation to this page, in multiple pages.
@aslams2020 sir, but new page should be of level 3 Am right ?
Hi @Shariq2003, Creating a new Page does not actually guarentee a level3. As it is not dependant on number of lines.
i reviewed -
movies
and comics
pages. Which make no difference in creating a different kind of development idea.I hope you understand, Why i gave level2 for it.
happy coding!
Hi @Shariq2003, Creating a new Page does not actually guarentee a level3. As it is not dependant on number of lines.
i reviewed -
- In the Blogs page, The navbar and footer are integrated from the homepage (as it should be)
- The layout of the cards and the styling of them is not newly styled as it is similar to
movies
andcomics
pages. Which make no difference in creating a different kind of development idea.- Also the page is not responsive
I hope you understand, Why i gave level2 for it.
happy coding!
@aslams2020 sir Okay what if I make it responsive in my new PR on which you don't have to add any level, just make this PR to level 3, after merging that PR
Fine ?
I can give that issue's PR Level1.
As this current PR will be a even then a level2, because of the 2nd point. As it is crucial to showcase our developer ideas in whatever work we do.
If you wish to make it responsive, please create an issue first.
I can give that issue's PR Level1.
As this current PR will be a even then a level2, because of the 2nd point. As it is crucial to showcase our developer ideas in whatever work we do.
If you wish to make it responsive, please create an issue first.
Yes sir, I just applied the same styling to match the theme of the website, nothing else.
Okay no problem sir, raising an issue for responsiveness
fix #255
I have added the Blogs Page that contain the Blogs,
Eg.
https://github.com/user-attachments/assets/fe541128-0420-44fa-bae2-81d9aa559422