search

aslanon / vue-confirm-dialog

Simple Confirm Dialog verification plugin with Vue.js.
https://aslanon.github.io/vue-confirm-dialog/
MIT License
190 stars 42 forks source link

Allow click on overlay to exit without running callback assuming false #11

Open adamtarmstrong opened 4 years ago

adamtarmstrong commented 4 years ago

Is your feature request related to a problem? Please describe. I would like to use this component more as a 2 option dialog (rather than a yes/no). Currently, if you click on the overlay then it behaves as "false" and runs the callback w/ false.

Describe the solution you'd like I'd like clicking on the overlay to simply close the entire component without actually making a "no" selection.

Describe alternatives you've considered The simplest solution would be to remove the callback on line 103, inside the method handleClickOverlay(). Or a more dynamic solution would be to allow you to define a separate onCancelCallback() to be used at init.

Additional context Thanks for considering this. Making this change would allow for backwards compatibility while providing a huge improvement in a small area.

aslanon commented 4 years ago

Thanks. I am working on this bug.

aviramha commented 4 years ago

Any update on this?

yourcharlie23 commented 3 years ago

Any update?

lamanhdai commented 2 years ago

any updates ?