=BG= allow absolute paths for `template` option

aslansky / css-sprite

css sprite generator

MIT License

734 stars 55 forks source link

=BG= allow absolute paths for `template` option #45

Closed bguiz closed 9 years ago

bguiz commented 9 years ago

absolute paths were previously simply getting concatenated on the end of process.cwd() using path.join()
use path.resolve() instead such that both absolute and relative paths work properly

coveralls commented 9 years ago

Coverage remained the same at 96.89% when pulling 11de4ae9abbed0d8b906a1c32c83a87e854a6d99 on bguiz:absolute-path-fix into 4f44f913973a7dc98647a424a8abdb1ccae1dc8e on aslansky:master.

bguiz commented 9 years ago

The output indicates that appveyor build failed because of a git clone issue, from the sounds of it, and none oif the tests were run, as it didn't even get to them.

Could you look into this?

Build started git clone -q git://github.com/aslansky/css-sprite.git C:\projects\css-sprite git fetch -q origin +refs/pull/45/merge: git checkout -qf FETCH_HEAD Specify a project or solution file. The directory does not contain a project or solution file.

aslansky commented 9 years ago

Thanks for the pull request. I was just playing around with appveyor and forgot to deactivate it. So don't worry about the failing.

bguiz commented 9 years ago

You're welcome!

Great work btw, I'm loving this sprite module because it has no external dependencies!

W: http://bguiz.com

On 5 February 2015 at 19:13, Alexander Slansky notifications@github.com wrote:

Thanks for the pull request. I was just playing around with appveyor and forgot to deactivate it. So don't worry about the failing.

— Reply to this email directly or view it on GitHub https://github.com/aslansky/css-sprite/pull/45#issuecomment-73009382.