search

aslansky / css-sprite

css sprite generator
MIT License
734 stars 55 forks source link

[retina support, fixes #42] Changed the call to lwip's resize() function to use the 'grid' interpolation method #50

Closed itayco closed 9 years ago

itayco commented 9 years ago

makes the resized image look much better.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 96.89% when pulling 68568adf9598c9a32c70fb73dd691c00a821e819 on itayco:master into 6d8261859ff7803fc9b5896c565fc04e70fb36f5 on aslansky:master.

aslansky commented 9 years ago

Nice one ... thanks.

leslc commented 9 years ago

Thanks @itayco! Going from 0.9.0 to 0.9.6 caused the jagged images for all curved lines. I had to use {interpolation: 'lanczos'} to make the curved lines smooth.

@aslansky, may I suggest going back to 'lanczos' as a default (as it's the lwip default)? The 'grid' was actually the worse setting for all my icons (40+), especially on retina. I can submit a PR for it as well.

leslc commented 9 years ago

Learned something new about use cases for different interpolation options: http://graphicdesign.stackexchange.com/questions/26385/difference-between-none-linear-cubic-and-sinclanczos3-interpolation-in-image