Use url.resolve(...) instead of path.join(...) to support abs URLs

aslansky / css-sprite

css sprite generator

MIT License

733 stars 55 forks source link

Use url.resolve(...) instead of path.join(...) to support abs URLs #55

Closed michaelmoussa closed 9 years ago

michaelmoussa commented 9 years ago

This PR adds support for using an absolute url for the --css-image-path, both in the form http://domain.com and //domain.com, which should resolve #48.

I've included a test for the new behavior and confirmed the existing tests still pass. Trying to use http://domain.com before would result in http:/domain.com, which wouldn't work as intended anyway, so there should not be any backwards compatibility issues here.

See http://stackoverflow.com/q/16301503/126531 for more information.

coveralls commented 9 years ago

Coverage increased (+0.02%) to 96.91% when pulling 60a01dcb0d224cc1f531f89def3206234576cc25 on michaelmoussa:abs-url-cssPath into 147f2a276086f1c3b40f88b3894370dea7572f9e on aslansky:master.

aslansky commented 9 years ago

Sir, thank you very much ;)

michaelmoussa commented 9 years ago

You're welcome! Glad to help. Can I trouble you to take a look at #56 as well and tag a release? Looking forward to adding this to our deployment process. :)