Brush-rotate cursor has display issues

[GoogleCodeExporter]

This is about the XOR rectangle that's used during brush rotation:
In zoomed view:
1) If the cursor is too near the separator, no display occurs.
In normal view (no matter if zoomed view is visible too):
2) If the cursor is too near the left border, no display occurs.
3) If the cursor is too near the top, it leaves 'droppings'
In all cases:
4) If the cursor is 'coming from' the menu on bottom, the arrow stays displayed

It's probably a very old issue, I remember seeing it when rotating large 'Text' 
brushes; I thought I had overflowed something due to unreasonable size, but it 
actually happens with any size.
I don't think there's a risk of crash, it must trigger the safety "left>right" 
in update_rect(). Still, this is rather embarrassing graphic glitch.

Original issue reported on code.google.com by yrizoud on 3 Feb 2012 at 11:24

[GoogleCodeExporter]

Original comment by yrizoud on 26 Sep 2012 at 12:24

• Changed state: Started

[GoogleCodeExporter]

Biggest (old!) problems fixed in r2011.
Still need to fix a compilation warning, maybe change how the "handle" behaves 
("right border" is not handy for huge brushes) and see if I can fix the messy 
graphics when holding SHIFT.

Original comment by yrizoud on 26 Sep 2012 at 12:40

[GoogleCodeExporter]

Graphic bug fixed in r2012. But XOR lines don't restrict to the ISO angles, 
this would need to move all the code that displays them from 
Display_cursor()/Hide_cursor() to the operation functions themselves. Maybe 
another day.

Original comment by yrizoud on 26 Sep 2012 at 11:16

• Changed state: Fixed