asleepwalkersdream / grafx2

Automatically exported from code.google.com/p/grafx2
0 stars 0 forks source link

PARENT DIRECTORY inserts the parent directory string (slash or ..) in filename #498

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Click button "load" or "save"
2. Select list entry "PARENT DIRECTORY"

What is the expected output? What do you see instead?
String field for filename should be empty. It contains a slash. (see attached 
image)

Problem is that a slash at beginning of a path means for AROS: go one directory 
level up. If a user enters a filename so that the string becomes e.g. 
"/mypic.png" the file would be stored in the parent directory of the current 
directory.

Original issue reported on code.google.com by mazzearos on 3 Aug 2012 at 12:23

Attachments:

GoogleCodeExporter commented 8 years ago
Oh I see, the problem is present for all OSes (It doesn't clear the .. on 
Windows).
When the user clicks the Filename field, the program should test if the 
selected directory is the fake entry 'parent directory' or a 'drive' entry 
(from 'select drive'). If this is the case, the field should be initially 
cleared.

Original comment by yrizoud on 3 Aug 2012 at 2:55

GoogleCodeExporter commented 8 years ago
Fixed in r1985. Now the filename gets cleared when you click it if the 
highlighted thing in the fileselected was anything other than a file; this also 
affect the 'select drive' screen. The behavior should be identical on all 
platforms.

Original comment by yrizoud on 11 Aug 2012 at 4:56

GoogleCodeExporter commented 8 years ago
Re-opened because of one unwanted side-effect:
If you begin "Save as" an existing file, and change the file format, Grafx2 
actualizes the file list (showing only files of usual file extensions for that 
format), and sets the filename extension to the default extension.
Now if you click the filename, instead of editing this "proposed filename", 
grafx2 clears it, so you have to re-type it.

The fix above should only take place if the "filename" is the same as the 
highlighted entry, taking into account filesystem case-sensitivity.

Original comment by yrizoud on 17 Sep 2012 at 12:32

GoogleCodeExporter commented 8 years ago
Normally fixed in r1995

Original comment by yrizoud on 17 Sep 2012 at 11:41

GoogleCodeExporter commented 8 years ago

Original comment by yrizoud on 17 Sep 2012 at 11:42