Merging into Lighthouse - Githubissues

aslushnikov / tracium

A blessed Chrome Trace parser.

Apache License 2.0

72 stars 7 forks source link

Merging into Lighthouse #2

Open aslushnikov opened 5 years ago

aslushnikov commented 5 years ago

It'd be nice to have Tracium integrated into Lighthouse repository. Tracium mostly picks files from Lighthouse as-is.

The only changes I had to do are:

substitute logging with DEBUG module
strip away sentry

The only new code is the 10 lines in //index.js.

@paulirish and @patrickhulce: WDYT?

patrickhulce commented 5 years ago

Love it 👍 I'm not sure we're getting any value by those particular Sentry captures at the moment anyway.

paulirish commented 4 years ago

roadmap: https://github.com/GoogleChrome/lighthouse/pull/8956#issuecomment-498923650

It'll be named tracehouse.

status: https://github.com/GoogleChrome/lighthouse/pull/9230 currently under review

soulgalore commented 4 years ago

Is this still the plan?

mbalabash commented 4 years ago

@aslushnikov @paulirish @patrickhulce Looks like your did great work and finished few steps from the roadmap. Do you have any updates for this migration? Is this still the plan?

patrickhulce commented 4 years ago

Lighthouse team stopped short of bullet 3 in that roadmap (https://github.com/GoogleChrome/lighthouse/pull/8956#issuecomment-498923650). The patches were ported and the tracehouse folder within Lighthouse should work generically, but it's not easily consumable anywhere as we did not reach consensus as a team on how to organize subpackages. I'll raise this again at our next eng sync meeting.

mbalabash commented 4 years ago

@patrickhulce Thank you. And many thanks to the lighthouse team for their work.

It would be great to accomplish this migration. A lot of useful tools and users depend on it. Few of them: size-limit, sitespeedio, estimo, size-limit-action, browsertime, etc.

mbalabash commented 4 years ago

Hello @patrickhulce Did you have a chance to discuss tracehouse issue with team? Do you have any updates?

mbalabash commented 4 years ago

Sorry for bothering you. I just have worried about this issue. Because tracium doesn't work stable with the latest chrome versions (81, 82, 83).

patrickhulce commented 4 years ago

Thanks for the poke @mbalabash! We decided how we're going to proceed (https://github.com/GoogleChrome/lighthouse/issues/9519#issuecomment-640914009) and it's just a matter of getting it done now. I'm moving more of my time back into lighthouse core this week, so I'd expect movement here by next week.

Will keep you posted 👍

mbalabash commented 4 years ago

@patrickhulce Thank you!

mbalabash commented 3 years ago

Hello, @patrickhulce I hope you're doing well.

Near month left since we last talked. Do you have any updates?

patrickhulce commented 3 years ago

I opened the first PRs in Lighthouse to make this happen but they are stagnating in review. I poked the reviewer yesterday, but I wouldn't get my hopes up for a swift turnaround.

mbalabash commented 3 years ago

@patrickhulce Thank you for your time!