search

aslushnikov / tracium

A blessed Chrome Trace parser.
Apache License 2.0
72 stars 7 forks source link

Add option to keep keepAttributableURLs #5

Closed soulgalore closed 5 years ago

soulgalore commented 5 years ago

Hi @aslushnikov would it be ok to add an option to keep the attributable URL? Thinking it could be good way to keep track of time spent for third party scripts.

Best Peter

patrickhulce commented 5 years ago

Oh +1! The attributableURLs are how https://github.com/patrickhulce/third-party-web gets all its data, making that easily verifiable and explorable by others would be 👌

Any objections @paulirish @aslushnikov ?

aslushnikov commented 5 years ago

@patrickhulce @soulgalore sure, we held off on exposing attributable URLs since we weren't sure if anybody needs them.

But since there are a few good usecases now... 👍

aslushnikov commented 5 years ago

Left an inline comment

@soulgalore nvm, I updated PR - hope you don't mind