search

asm-js / validator

A reference validator for asm.js.
Apache License 2.0
1.78k stars 148 forks source link

Spec inconsistent for ! and ~~ #62

Closed cscott closed 10 years ago

cscott commented 11 years ago

The latest spec contains inconsistent information for ! and ~~.

The "Unary operators" table contains ! but it is missing from the UnaryExpression production. Conversely, UnaryExpression mentions ~~, but it is missing from the "Unary operators" table.

cscott commented 11 years ago

Bug #49 may be related?

cscott commented 11 years ago

To make this concrete: ! should be added to the first production in the UnaryExpression section. ~~ should be added, with type (double)->signed, to the "Unary operators" table at the end.

sunfishcode commented 10 years ago

These are both implemented in 7881fbe325fbfbeed1caf5d1d48b8c5f121ead2d.